Even though the triggered ability affects only attacking creatures, the bonuses will remain for the rest of the turn.

Victory’s Herald also gains flying (which will likely be redundant) and lifelink if it’s still attacking when the ability resolves.